Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix part of issue #3128 - None should not be a valid type for 'url' in Response.follow #3131

Merged
merged 3 commits into from
Feb 21, 2018

Conversation

NewUserHa
Copy link
Contributor

the issue reason should be: 'urljoin from urllib return baseurl if targeturl is None'

the empty url issue haven't been touched because @kmike says: 'this is an intended behavior.'

because @kmike posted: 'If url is '', Scrapy should follow the same page, this is an intended behavior.'
because @kmike posted: 'If url is '', Scrapy should follow the same page, this is an intended behavior.'
Copy link
Contributor Author

@NewUserHa NewUserHa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue reason should be: 'urljoin from urllib return baseurl if targeturl is None'

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #3131 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
+ Coverage    82.1%   82.11%   +<.01%     
==========================================
  Files         228      228              
  Lines        9586     9588       +2     
  Branches     1384     1385       +1     
==========================================
+ Hits         7871     7873       +2     
  Misses       1456     1456              
  Partials      259      259
Impacted Files Coverage Δ
scrapy/http/response/__init__.py 93.44% <100%> (+0.22%) ⬆️

@cathalgarvey cathalgarvey changed the title fix one issue of issue#3128 [MRG+1] Fix one issue of issue#3128 Feb 21, 2018
@cathalgarvey cathalgarvey changed the title [MRG+1] Fix one issue of issue#3128 [MRG+1] Fix part of issue #3128 - None should not be a valid type for 'url' in Response.follow Feb 21, 2018
@kmike
Copy link
Member

kmike commented Feb 21, 2018

Thanks @NewUserHa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants