Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Run tests for Python 3.7 #3150

Merged
merged 5 commits into from Jul 11, 2018
Merged

[WIP] Run tests for Python 3.7 #3150

merged 5 commits into from Jul 11, 2018

Conversation

@patiences
Copy link
Contributor

@patiences patiences commented Mar 2, 2018

No description provided.

@patiences patiences mentioned this pull request Mar 2, 2018
@lopuhin
Copy link
Member

@lopuhin lopuhin commented Mar 2, 2018

The build does not show in GH UI for some reason, but here it is: https://travis-ci.org/scrapy/scrapy/builds/348250229

@patiences
Copy link
Contributor Author

@patiences patiences commented Mar 2, 2018

Looks like 3.7 errored out (in 19sec)! It seems that the error log is unavailable, any advice on how to debug this? :-)

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Mar 2, 2018

Indeed, there is no output. I restarted the build, it might help to get some output (edit: it doesn't even restart!). Also travis seems to not support 3.7 yet, but only 3.7-dev: https://docs.travis-ci.com/user/languages/python/#Specifying-Python-versions, so python: 3.7-dev should be more correct, while TOXENV should probably still be py37

@codecov
Copy link

@codecov codecov bot commented Mar 2, 2018

Codecov Report

Merging #3150 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3150   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         228      228           
  Lines        9588     9588           
  Branches     1385     1385           
=======================================
  Hits         7873     7873           
  Misses       1456     1456           
  Partials      259      259
@patiences
Copy link
Contributor Author

@patiences patiences commented Mar 2, 2018

@lopuhin Done! Thank you so much for your help.

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Mar 2, 2018

Great, now the build worked: https://travis-ci.org/scrapy/scrapy/jobs/348294263

Unfortunately, the twisted syntax error issue is blocking many tests, and it can be a while before the fix is it's merged and new twisted version is released. In the meantime, it's possible to install twisted from a branch.

@nctl144
Copy link
Member

@nctl144 nctl144 commented Mar 2, 2018

I believe this is for this issue #3143 right :)

@patiences
Copy link
Contributor Author

@patiences patiences commented Mar 4, 2018

@lopuhin yep, yikes! Do you mean that I should use the PR version of Twisted that fixes the syntax error issue temporarily so that we can run the tests? How can I do that? :-)

@nctl144 yes it is!

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Mar 5, 2018

Do you mean that I should use the PR version of Twisted that fixes the syntax error issue temporarily so that we can run the tests? How can I do that? :-)

@patiences yes - the easiest way seems to change requirements.txt and install Twisted from a branch on github instead of from PyPI - this way it will be picked up both locally (with/without tox) and on travis.

@patiences
Copy link
Contributor Author

@patiences patiences commented Mar 5, 2018

@lopuhin 3.7 tests pass in the most recent build, yay! :-)

But I'm not sure what's up with the jessie test failures -- they should not have been affected by these changes. Is this test suite known to be unstable?

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Mar 5, 2018

3.7 tests pass in the most recent build, yay! :-)

Awesome, great news! I expected some failures, thanks for doing this!

But I'm not sure what's up with the jessie test failures -- they should not have been affected by these changes. Is this test suite known to be unstable?

I agree, there should be no difference for jessie, it might unstable indeed, let me try restarting this job.

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Mar 5, 2018

Now all builds have passed, I'll raise an issue if I see it failing again.

Current status: Python 3.7 tests added to tox and travis, but they use not yet merged PR to Twisted. Waiting for PR to get merged.

@patiences
Copy link
Contributor Author

@patiences patiences commented Mar 5, 2018

Great, thank you so much @lopuhin for all your help on this! :-)

@@ -23,6 +23,8 @@ matrix:
env: TOXENV=py36
- python: 3.6
env: TOXENV=docs
- python: 3.7-dev

This comment has been minimized.

@kmike

kmike Jul 4, 2018
Member

I think now, as 3.7 is released, it may be better to use Python 3.7 relase (though it may be not straightforward); according to travis-ci/travis-ci#9815 3.7-dev is an old beta.

@kmike kmike added this to the v1.6 milestone Jul 4, 2018
@lopuhin lopuhin mentioned this pull request Jul 9, 2018
@kmike kmike merged commit f10a43d into scrapy:master Jul 11, 2018
2 checks passed
2 checks passed
@codecov
codecov/patch Coverage not affected when comparing acd2b8d...f10a43d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike
Copy link
Member

@kmike kmike commented Jul 11, 2018

Resumed in #3326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants