[MRG+1] add ftp to the link extractor scheme list #3152
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3152 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 228 228
Lines 9588 9588
Branches 1385 1385
=======================================
Hits 7873 7873
Misses 1456 1456
Partials 259 259
|
Thank you @kmike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This might be the solution to the issue mentioned in #1381. I thought it might be a good idea to solve it :). I added ftp to link extractor so it recognizes ftp links. Please let me know if there's anything that I can do to improve this PR😄