Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] add ftp to the link extractor scheme list #3152

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@nctl144
Copy link
Member

commented Mar 3, 2018

This might be the solution to the issue mentioned in #1381. I thought it might be a good idea to solve it :). I added ftp to link extractor so it recognizes ftp links. Please let me know if there's anything that I can do to improve this PR 馃槃

@codecov

This comment has been minimized.

Copy link

commented Mar 3, 2018

Codecov Report

Merging #3152 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3152   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         228      228           
  Lines        9588     9588           
  Branches     1385     1385           
=======================================
  Hits         7873     7873           
  Misses       1456     1456           
  Partials      259      259
Impacted Files Coverage 螖
scrapy/linkextractors/__init__.py 100% <100%> (酶) 猬嗭笍

@kmike kmike changed the title add ftp to the scheme list [MRG+1] add ftp to the scheme list Jul 4, 2018

@kmike

This comment has been minimized.

Copy link
Member

commented Jul 4, 2018

Thanks @nctl144! I think it is a right thing to do. We have some issues with processing ftp links (see #2505), but I think it still makes sense to extract them in link extractors.

@kmike kmike added this to the v1.6 milestone Jul 5, 2018

@nctl144

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2018

Thank you @kmike 馃槃

@dangra dangra merged commit 9c6d265 into scrapy:master Jul 11, 2018

2 checks passed

codecov/patch 100% of diff hit (target 82.11%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nctl144 nctl144 deleted the nctl144:ftp_linkextractors branch Jul 11, 2018

@kmike kmike changed the title [MRG+1] add ftp to the scheme list [MRG+1] add ftp to the link extractor scheme list Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.