Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Doc: update wording for COOKIES_ENABLED #3189

Merged
merged 1 commit into from Apr 5, 2018

Conversation

@stav
Copy link
Contributor

@stav stav commented Mar 27, 2018

I just wanted to make the description flow a little better and also add the reqmeta for better linking.

@codecov
Copy link

@codecov codecov bot commented Mar 27, 2018

Codecov Report

Merging #3189 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
- Coverage   82.12%   82.11%   -0.02%     
==========================================
  Files         228      228              
  Lines        9593     9593              
  Branches     1385     1385              
==========================================
- Hits         7878     7877       -1     
  Misses       1456     1456              
- Partials      259      260       +1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️
``Request.``:reqmeta:`meta['dont_merge_cookies'] <dont_merge_cookies>`
evaluates to ``True`` the request cookies will **not** be sent to the
web server and received cookies in :class:`~scrapy.http.Response` will
**not** be merged with the existing cookies.

This comment has been minimized.

@kmike

kmike Mar 28, 2018
Member

👍

@kmike
Copy link
Member

@kmike kmike commented Mar 28, 2018

Looks good to me, thanks @stav!
I haven't checked how updated :reqmeta: looks like in the docs, but I assume you've checked it and it looks fine.

@kmike kmike changed the title Doc: update wording for COOKIES_ENABLED [MRG+1] Doc: update wording for COOKIES_ENABLED Mar 28, 2018
@stav
Copy link
Contributor Author

@stav stav commented Mar 28, 2018

Yep, rendered everything and it all looks good.

@lopuhin lopuhin merged commit da1256a into scrapy:master Apr 5, 2018
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 6c3970e...c6d20bd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lopuhin
Copy link
Member

@lopuhin lopuhin commented Apr 5, 2018

Thanks @stav !

@kmike kmike added this to the v1.6 milestone Jul 4, 2018
@kmike kmike modified the milestones: v1.6, v1.5.1 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.