[MRG+1] Update depth middleware stats (fixes #3245) #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rpkilby Problem with unit-tests was fixed in master. Can you merge master to this PR? |
Codecov Report
@@ Coverage Diff @@
## master #3253 +/- ##
==========================================
+ Coverage 82.12% 82.13% +<.01%
==========================================
Files 228 228
Lines 9599 9598 -1
Branches 1385 1384 -1
==========================================
Hits 7883 7883
Misses 1457 1457
+ Partials 259 258 -1
|
|
Updated |
|
Thanks @rpkilby, it looks good! |
kmike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPTH_STATS_VERBOSEinstead ofDEPTH_STATS, which is not currently used.self.statschecks, as stats are always provided (no way to not provide a stats object).(fixes #3245)