Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3264, unhandled error :AttributeError: "NoneType" object has no att… #3265

Closed
wants to merge 1 commit into from

Conversation

wangrenlei
Copy link

Fixed the issue I've mentioned there, this is the pull request to merge, (added one line), hope all is fine.
#3264

@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #3265 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3265      +/-   ##
==========================================
- Coverage   82.12%   82.11%   -0.01%     
==========================================
  Files         228      228              
  Lines        9599     9600       +1     
  Branches     1385     1386       +1     
==========================================
  Hits         7883     7883              
- Misses       1457     1458       +1     
  Partials      259      259
Impacted Files Coverage Δ
scrapy/commands/parse.py 20.93% <0%> (-0.13%) ⬇️

@Gallaecio
Copy link
Member

@wangrenlei So, almost 4 years later, am I right to assume you have moved on?

I am thinking we should include a test before merging. But given how long it has been, I don’t expect you to do it, we probably need to do it ourselves or get someone else to do it.

PS: I am closing and reopening to trigger a new CI run.

@Gallaecio Gallaecio closed this Mar 17, 2022
@Gallaecio
Copy link
Member

Oh. I cannot actually reopen since the source repository is gone.

@Gallaecio
Copy link
Member

Well, there is #5376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants