Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Improve docs of S3 Storage to make Python version more explicit #3294

Merged
merged 1 commit into from Jun 27, 2018
Merged

[MRG+1] Improve docs of S3 Storage to make Python version more explicit #3294

merged 1 commit into from Jun 27, 2018

Conversation

@rennerocha
Copy link
Contributor

@rennerocha rennerocha commented Jun 13, 2018

The documentation of the S3 storage backend (https://doc.scrapy.org/en/latest/topics/feed-exports.html#s3) suggest the use of the libraries botocore (https://github.com/boto/botocore) or boto (https://github.com/boto/boto). However, boto library will work only if the user is using Python 2 (as it is correctly explained here https://doc.scrapy.org/en/latest/topics/feed-exports.html#storages).

Besides the fact of this information is there, I believe that it would be better for the user reading the documentation to have this note also inside the specific section of S3 storage backend.

When issue #1866 is resolved, this could be removed anyway.

@codecov
Copy link

@codecov codecov bot commented Jun 13, 2018

Codecov Report

Merging #3294 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3294   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         228      228           
  Lines        9599     9599           
  Branches     1385     1385           
=======================================
  Hits         7885     7885           
  Misses       1456     1456           
  Partials      258      258
@kmike kmike changed the title Improve docs of S3 Storage to make Python version more explicit [MRG+1] Improve docs of S3 Storage to make Python version more explicit Jun 14, 2018
@dangra dangra merged commit 594a441 into scrapy:master Jun 27, 2018
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing c6030ce...e2bb218
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
@kmike kmike modified the milestones: v1.6, v1.5.1 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants