Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] fix the test case name of HttpProxyMiddleware #3299

Merged
merged 1 commit into from Jun 21, 2018
Merged

[MRG+1] fix the test case name of HttpProxyMiddleware #3299

merged 1 commit into from Jun 21, 2018

Conversation

@grammy-jiang
Copy link
Contributor

@grammy-jiang grammy-jiang commented Jun 20, 2018

As the title said, fix the test case name.

@lopuhin lopuhin changed the title fix the test case name of HttpProxyMiddleware [MRG+1] fix the test case name of HttpProxyMiddleware Jun 20, 2018
Copy link
Member

@lopuhin lopuhin left a comment

Good catch, thanks @grammy-jiang !

@codecov
Copy link

@codecov codecov bot commented Jun 20, 2018

Codecov Report

Merging #3299 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3299   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         228      228           
  Lines        9605     9605           
  Branches     1387     1387           
=======================================
  Hits         7890     7890           
  Misses       1458     1458           
  Partials      257      257
@kmike kmike merged commit 1fd1702 into scrapy:master Jun 21, 2018
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 991e9b8...88bd067
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants