TST exclude lxml==4.2.2 from tests #3308
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3308 +/- ##
==========================================
+ Coverage 78.72% 81.74% +3.01%
==========================================
Files 228 228
Lines 9605 9605
Branches 1337 1337
==========================================
+ Hits 7562 7852 +290
+ Misses 1773 1487 -286
+ Partials 270 266 -4
|
I have met this problem these days, and I have several PRs and their testings to wait to pass. But sorry I am not familiar with the image related libraries, could not provide any help. Hope this issue could be fixed soon. |
@grammy-jiang this is actually caused by lxml (see python-pillow/Pillow#3208); lxml reverted the offending commit in a new release (lxml/lxml#265). So the fix would be to exclude bad lxml version, I'll do it in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR is an example of Travis-driven development, as I can't reproduce an issue locally on OS X.
TODO: fix it. It seems the issue is related to PNG codec, as JPEG images work.