[MRG+1] TST test agains latest pypy #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopuhin
changed the title
|
The problem is that tests segfault with pypy3 6.0 :) |
it segfaults for some reason
Codecov Report
@@ Coverage Diff @@
## master #3309 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 228 228
Lines 9605 9605
Branches 1387 1387
=======================================
Hits 7890 7890
Misses 1458 1458
Partials 257 257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is better to test against latest pypy, as it is still a moving target, and we don't absolutely need to support older pypy versions.