Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] TST test agains latest pypy #3309

Merged
merged 2 commits into from Jun 27, 2018
Merged

[MRG+1] TST test agains latest pypy #3309

merged 2 commits into from Jun 27, 2018

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jun 26, 2018

I think it is better to test against latest pypy, as it is still a moving target, and we don't absolutely need to support older pypy versions.

@lopuhin lopuhin changed the title TST test agains latest pypy [MRG+1] TST test agains latest pypy Jun 27, 2018
Copy link
Member

@lopuhin lopuhin left a comment

@kmike I agree, thanks for updating it!

@kmike
Copy link
Member Author

@kmike kmike commented Jun 27, 2018

The problem is that tests segfault with pypy3 6.0 :)

it segfaults for some reason
@codecov
Copy link

@codecov codecov bot commented Jun 27, 2018

Codecov Report

Merging #3309 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3309   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         228      228           
  Lines        9605     9605           
  Branches     1387     1387           
=======================================
  Hits         7890     7890           
  Misses       1458     1458           
  Partials      257      257
@kmike kmike merged commit 8782901 into master Jun 27, 2018
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 1fd1702...486753f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike kmike deleted the tst-upgrade-pypy branch Jun 27, 2018
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants