Enable AppVeyor CI for running test suite on Windows env #3315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3315 +/- ##
==========================================
- Coverage 84.39% 84.36% -0.04%
==========================================
Files 167 167
Lines 9361 9361
Branches 1390 1390
==========================================
- Hits 7900 7897 -3
- Misses 1206 1209 +3
Partials 255 255
|
all green @kmike ! ready to review and get it merged for 1.6 release |
tests/test_feedexport.py
Outdated
shutil.rmtree(tmpdir) | ||
# FIXME: Windows fails to remove the file because FeedExporter | ||
# keeps a reference to the temporal file even after | ||
# the spider finished. |
kmike
Aug 15, 2018
Member
Should we open an issue for that?
Should we open an issue for that?
dangra
Aug 15, 2018
Author
Member
+1
+1
tests/test_feedexport.py
Outdated
# keeps a reference to the temporal file even after | ||
# the spider finished. | ||
try: | ||
shutil.rmtree(tmpdir) |
kmike
Aug 15, 2018
Member
can we use rmtree(tmpdir, ignore_errors=True)
?
can we use rmtree(tmpdir, ignore_errors=True)
?
dangra
Aug 15, 2018
Author
Member
Good idea. fixing.
Good idea. fixing.
Awesome, thanks @dangra for picking this up and @jdemaeyer for the initial work! |
TY @kmike. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Test windows builds on Appveyor CI.
Closes #1684