New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AppVeyor CI for running test suite on Windows env #3315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3315 +/- ##
==========================================
- Coverage 84.39% 84.36% -0.04%
==========================================
Files 167 167
Lines 9361 9361
Branches 1390 1390
==========================================
- Hits 7900 7897 -3
- Misses 1206 1209 +3
Partials 255 255
|
64bb13d
to
cb28175
Compare
1492e1f
to
a304d6b
Compare
all green @kmike ! ready to review and get it merged for 1.6 release 👯 |
tests/test_feedexport.py
Outdated
shutil.rmtree(tmpdir) | ||
# FIXME: Windows fails to remove the file because FeedExporter | ||
# keeps a reference to the temporal file even after | ||
# the spider finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we open an issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/test_feedexport.py
Outdated
# keeps a reference to the temporal file even after | ||
# the spider finished. | ||
try: | ||
shutil.rmtree(tmpdir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use rmtree(tmpdir, ignore_errors=True)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. fixing.
Awesome, thanks @dangra for picking this up and @jdemaeyer for the initial work! |
TY @kmike. |
Test windows builds on Appveyor CI.
Closes #1684