Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AppVeyor CI for running test suite on Windows env #3315

Merged
merged 21 commits into from Aug 15, 2018
Merged

Conversation

@dangra
Copy link
Member

@dangra dangra commented Jul 3, 2018

Test windows builds on Appveyor CI.
Closes #1684

@codecov
Copy link

@codecov codecov bot commented Jul 3, 2018

Codecov Report

Merging #3315 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3315      +/-   ##
==========================================
- Coverage   84.39%   84.36%   -0.04%     
==========================================
  Files         167      167              
  Lines        9361     9361              
  Branches     1390     1390              
==========================================
- Hits         7900     7897       -3     
- Misses       1206     1209       +3     
  Partials      255      255
Impacted Files Coverage Δ
scrapy/commands/startproject.py 100% <100%> (ø) ⬆️
scrapy/utils/python.py 82.68% <0%> (-1.68%) ⬇️
@kmike
Copy link
Member

@kmike kmike commented Jul 3, 2018

A related pull request: #1756, though I hope many of the workarounds from that PR are not needed now.

A ticket to close once we make it working: #1684.

@kmike kmike mentioned this pull request Jul 3, 2018
@kmike kmike added this to the v1.6 milestone Jul 4, 2018
@dangra dangra force-pushed the test-on-windows branch from 64bb13d to cb28175 Aug 15, 2018
@dangra dangra force-pushed the test-on-windows branch from 1492e1f to a304d6b Aug 15, 2018
@dangra dangra requested review from kmike and lopuhin Aug 15, 2018
@dangra
Copy link
Member Author

@dangra dangra commented Aug 15, 2018

all green @kmike ! ready to review and get it merged for 1.6 release 👯

shutil.rmtree(tmpdir)
# FIXME: Windows fails to remove the file because FeedExporter
# keeps a reference to the temporal file even after
# the spider finished.

This comment has been minimized.

@kmike

kmike Aug 15, 2018
Member

Should we open an issue for that?

This comment has been minimized.

@dangra

dangra Aug 15, 2018
Author Member

+1

This comment has been minimized.

@dangra

dangra Aug 15, 2018
Author Member

# keeps a reference to the temporal file even after
# the spider finished.
try:
shutil.rmtree(tmpdir)

This comment has been minimized.

@kmike

kmike Aug 15, 2018
Member

can we use rmtree(tmpdir, ignore_errors=True)?

This comment has been minimized.

@dangra

dangra Aug 15, 2018
Author Member

Good idea. fixing.

@kmike
Copy link
Member

@kmike kmike commented Aug 15, 2018

Awesome, thanks @dangra for picking this up and @jdemaeyer for the initial work!

@kmike kmike merged commit 91f986e into master Aug 15, 2018
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 84.39%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra
Copy link
Member Author

@dangra dangra commented Aug 15, 2018

TY @kmike.
Everyone knows @jdemaeyer is the master chef! I am here just to cleanup the dishes.

@dangra dangra deleted the test-on-windows branch Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants