Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Delete relocation shims #3318

Merged
merged 3 commits into from Jul 6, 2018
Merged

[MRG+1] Delete relocation shims #3318

merged 3 commits into from Jul 6, 2018

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jul 5, 2018

Fixes #2568.

  • relocation shims are removed (deprecated in Scrapy 1.0)
  • SpiderManager shim is removed (deprecated in Scrapy 1.0)
  • scrapy.project and scrapy.stats are removed (they raise an error for 4 years)

Ancient scrapy.log and scrapy.conf shims are not removed, as I suspect they can still have some use. Should we be more aggressive towards them?

scrapy.telnet shim is also untouched, since it was a part of Scrapy 1.1.0 (2016-05-11) - just two years, not 3 like other shims. scrapy.xlib shims are more recent.

@kmike kmike added this to the v1.6 milestone Jul 5, 2018
@lopuhin
lopuhin approved these changes Jul 6, 2018
Copy link
Member

@lopuhin lopuhin left a comment

Looks good, thanks @kmike !

@lopuhin lopuhin changed the title Delete relocation shims [MRG+1] Delete relocation shims Jul 6, 2018
@dangra dangra merged commit 666e237 into master Jul 6, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra deleted the delete-relocation-shims branch Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants