Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Remove deprecated CrawlerSettings class and Settings attributes #3327

Merged
merged 1 commit into from Jul 11, 2018

Conversation

@nyov
Copy link
Contributor

@nyov nyov commented Jul 9, 2018

On the heels of removing those relocation shims, I believe the time has come for CrawlerSettings, Settings.overrides and Settings.defaults as well.
(...is deprecated and won't be supported in Scrapy 0.26 ... yah, right. Lies!)

As a note to anyone napping the last four years; use Settings.set(name, value, priority='cmdline') (overrides) and Settings.set(name, value, priority='default') (defaults) instead.

@kmike kmike changed the title Remove deprecated CrawlerSettings class and Settings attributes [MRG+1] Remove deprecated CrawlerSettings class and Settings attributes Jul 9, 2018
@kmike
Copy link
Member

@kmike kmike commented Jul 9, 2018

Looks good to me, thanks for the cleanup @nyov!

@kmike kmike added this to the v1.6 milestone Jul 11, 2018
@dangra dangra merged commit 01e317e into scrapy:master Jul 11, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nyov nyov deleted the nyov:deprecations branch Jul 12, 2018
kmike added a commit that referenced this pull request Jul 31, 2018
This is a follow-up to #3327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants