Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default RETRY_HTTP_CODES on docs #3335

Merged
merged 1 commit into from Jul 18, 2018
Merged

update default RETRY_HTTP_CODES on docs #3335

merged 1 commit into from Jul 18, 2018

Conversation

@stummjr
Copy link
Member

@stummjr stummjr commented Jul 13, 2018

The docs on RETRY_HTTP_CODES are outdated in regards to the list of HTTP status codes that are retried by default by the RetryMiddleware.

Here's the updated list: https://github.com/scrapy/scrapy/blob/master/scrapy/settings/default_settings.py#L239

@stummjr stummjr added the docs label Jul 13, 2018
@codecov
Copy link

@codecov codecov bot commented Jul 13, 2018

Codecov Report

Merging #3335 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3335   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files         167      167           
  Lines        9340     9340           
  Branches     1384     1384           
=======================================
  Hits         7868     7868           
  Misses       1219     1219           
  Partials      253      253

@kmike kmike added this to the v1.6 milestone Jul 18, 2018
@kmike
Copy link
Member

@kmike kmike commented Jul 18, 2018

A great catch! FTR: we forgot to update them here: #2852.

@kmike kmike merged commit 258121d into master Jul 18, 2018
2 checks passed
@kmike kmike deleted the docs-retry-codes branch Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants