Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Include flags when copying requests #3342

Merged
merged 1 commit into from Jul 25, 2018

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented Jul 19, 2018

I noticed flags were missing after a request was retried by the retry downloader middleware, traced the issue and realized that they were not being copied.
Small test case included.

@codecov
Copy link

@codecov codecov bot commented Jul 19, 2018

Codecov Report

Merging #3342 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3342   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files         167      167           
  Lines        9340     9340           
  Branches     1384     1384           
=======================================
  Hits         7868     7868           
  Misses       1219     1219           
  Partials      253      253
Impacted Files Coverage Δ
scrapy/http/request/__init__.py 100% <100%> (ø) ⬆️
@kmike kmike changed the title Include flags when copying requests [MRG+1] Include flags when copying requests Jul 19, 2018
@kmike
Copy link
Member

@kmike kmike commented Jul 19, 2018

A good catch, thanks @elacuesta!

@kmike kmike added this to the v1.6 milestone Jul 19, 2018
@dangra dangra merged commit b6abd45 into scrapy:master Jul 25, 2018
2 checks passed
2 checks passed
codecov/patch 100% of diff hit (target 84.23%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elacuesta elacuesta deleted the elacuesta:copy-request-flags branch Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants