[MRG+1] Use dont_filter=True for contracts requests #3381
@@ Coverage Diff @@ ## master #3381 +/- ## ========================================== + Coverage 84.48% 84.49% +<.01% ========================================== Files 167 167 Lines 9371 9376 +5 Branches 1392 1392 ========================================== + Hits 7917 7922 +5 Misses 1199 1199 Partials 255 255
@kmike I can't start
class TestSameUrlSpider(Spider): def parse_first(self, response): """first callback @url http://scrapy.org """ pass def parse_second(self, response): """second callback @url http://scrapy.org """ pass class ContractsManagerTest(unittest.TestCase): contracts = [UrlContract, ReturnsContract, ScrapesContract] def setUp(self): self.conman = ContractsManager(self.contracts) self.results = TextTestResult(stream=None, descriptions=False, verbosity=0) def test_same_url(self): crawler_process = CrawlerProcess() TestSameUrlSpider.start_requests = lambda s: self.conman.from_spider(s, self.results) crawler_process.crawl(TestSameUrlSpider) crawler_process.start() self.assertEqual(self.results.testsRun, 2)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.