Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] PEP8 ofsite middleware #3405

Merged
merged 1 commit into from Aug 28, 2018
Merged

[MRG+1] PEP8 ofsite middleware #3405

merged 1 commit into from Aug 28, 2018

Conversation

@stav
Copy link
Contributor

@stav stav commented Aug 24, 2018

No description provided.

@kmike kmike changed the title PEP8 ofsite middleware [MRG+1] PEP8 ofsite middleware Aug 28, 2018
@kmike
Copy link
Member

@kmike kmike commented Aug 28, 2018

Looks good, thanks @stav!
//cc @dangra - do you have any idea why is AppVeyor failing?

@kmike kmike added this to the v1.6 milestone Aug 28, 2018
@dangra
Copy link
Member

@dangra dangra commented Aug 28, 2018

no idea yet

FTR

================================== FAILURES ===================================
____________ CrawlerRunnerTestCase.test_spidermanager_deprecation _____________
self = <tests.test_crawler.CrawlerRunnerTestCase testMethod=test_spidermanager_deprecation>
    def test_spidermanager_deprecation(self):
        with warnings.catch_warnings(record=True) as w:
            runner = CrawlerRunner({
                'SPIDER_MANAGER_CLASS': 'tests.test_crawler.CustomSpiderLoader'
            })
            self.assertIsInstance(runner.spider_loader, CustomSpiderLoader)
>           self.assertEqual(len(w), 1)
C:\projects\scrapy\tests\test_crawler.py:177: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
c:\projects\scrapy\.tox\py36\lib\site-packages\twisted\trial\_synctest.py:432: in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
E   twisted.trial.unittest.FailTest: 3 != 1
@dangra
Copy link
Member

@dangra dangra commented Aug 28, 2018

and restarting the build "fixed" it 😕

@dangra dangra merged commit 0007cd0 into scrapy:master Aug 28, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants