Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Add Bug report and Feature request templates #3471

Merged
merged 5 commits into from Aug 26, 2019

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Oct 22, 2018

(Almost) Shamelessly copied from the Atom repository 馃槆

Lately I've been seeing a great deal of support questions at the Github issue tracker, things that should go to other channels like the StackOverflow "scrapy" tag. Hopefully this change could help with that.

Update: fixes #3749

@elacuesta
Copy link
Member Author

@elacuesta elacuesta commented Oct 22, 2018

Oh no, there is already a PR for this at #3126 馃う鈥嶁檪锔

@elacuesta elacuesta closed this Oct 22, 2018
@Gallaecio Gallaecio changed the title Add Bug report and Feature request templates [MRG+1] Add Bug report and Feature request templates Jul 29, 2019

## Additional context

Add any other context or screenshots about the feature request here.
Copy link
Member

@kmike kmike Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we're getting quite a lot of screenshots of IDEs with source code, we should probably discourage screenshots, not encourage them :)

Copy link
Member Author

@elacuesta elacuesta Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, I missed that one. Just updated that and a few other parts to be clearer. Thanks for noticing!

@codecov
Copy link

@codecov codecov bot commented Aug 1, 2019

Codecov Report

Merging #3471 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3471   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         164      164           
  Lines        9565     9565           
  Branches     1435     1435           
=======================================
  Hits         8184     8184           
  Misses       1133     1133           
  Partials      248      248

@codecov
Copy link

@codecov codecov bot commented Aug 1, 2019

Codecov Report

Merging #3471 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
- Coverage   85.56%   85.48%   -0.09%     
==========================================
  Files         164      165       +1     
  Lines        9565     9622      +57     
  Branches     1435     1446      +11     
==========================================
+ Hits         8184     8225      +41     
- Misses       1133     1144      +11     
- Partials      248      253       +5
Impacted Files Coverage 螖
scrapy/core/downloader/tls.py 88.88% <0%> (-1.12%) 猬囷笍
scrapy/core/downloader/handlers/http10.py 100% <0%> (酶) 猬嗭笍
scrapy/pipelines/files.py 66.53% <0%> (酶) 猬嗭笍
scrapy/logformatter.py 90.47% <0%> (酶) 猬嗭笍
scrapy/core/downloader/handlers/http11.py 92.53% <0%> (酶) 猬嗭笍
scrapy/utils/ssl.py 52.77% <0%> (酶)
scrapy/settings/default_settings.py 98.67% <0%> (酶) 猬嗭笍
scrapy/utils/conf.py 89.7% <0%> (+0.31%) 猬嗭笍
scrapy/core/downloader/contextfactory.py 75% <0%> (+4.03%) 猬嗭笍
scrapy/_monkeypatches.py 72.72% <0%> (+15.58%) 猬嗭笍

kmike
kmike approved these changes Aug 19, 2019
Copy link
Member

@kmike kmike left a comment

I like it 馃憤

@Gallaecio Gallaecio merged commit 3abe7e6 into scrapy:master Aug 26, 2019
2 checks passed
@elacuesta elacuesta deleted the issue_templates branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants