Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Include additional files in sdists #3495

Merged
merged 1 commit into from Nov 20, 2018
Merged

Conversation

@toddrme2178
Copy link
Contributor

@toddrme2178 toddrme2178 commented Nov 16, 2018

In particular this includes files needed for running the tests, as well as the changelog.

In particular this includes files needed for running the tests, as well as the changelog.
@codecov
Copy link

@codecov codecov bot commented Nov 16, 2018

Codecov Report

Merging #3495 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3495   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         167      167           
  Lines        9376     9376           
  Branches     1392     1392           
=======================================
  Hits         7912     7912           
  Misses       1206     1206           
  Partials      258      258
@kmike kmike changed the title Include additional files in sdists [MRG+1] Include additional files in sdists Nov 19, 2018
@kmike
Copy link
Member

@kmike kmike commented Nov 19, 2018

Thanks @toddrme2178! I think that's fine to add them, I don't see any downsides.

Any particular reason you want them to be included?

@lopuhin
Copy link
Member

@lopuhin lopuhin commented Nov 20, 2018

@toddrme2178 thanks for taking care of this, since we already include tests, makes sense to include all supporting files as well.

@lopuhin lopuhin merged commit 886513c into scrapy:master Nov 20, 2018
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing dc65e75...491929c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike kmike added this to the v1.6 milestone Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants