Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Add documentation to scrapy shell command. #3496

Merged
merged 1 commit into from Dec 26, 2018

Conversation

@frederik-elwert
Copy link
Contributor

@frederik-elwert frederik-elwert commented Nov 16, 2018

The special syntax required for local files (./file.html) is not documented as part of the scrapy shell --help output. This patch adds that.

The special syntax required for local files (`./file.html`) is not documented as part of the `scrapy shell --help` output. This patch adds that.
@codecov
Copy link

@codecov codecov bot commented Nov 16, 2018

Codecov Report

Merging #3496 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3496   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         167      167           
  Lines        9376     9376           
  Branches     1392     1392           
=======================================
  Hits         7912     7912           
  Misses       1206     1206           
  Partials      258      258
Impacted Files Coverage Δ
scrapy/commands/shell.py 92.85% <100%> (ø) ⬆️
@kmike kmike changed the title Add documentation to scrapy shell command. [MRG+1] Add documentation to scrapy shell command. Nov 19, 2018
@kmike
Copy link
Member

@kmike kmike commented Nov 19, 2018

A good usability improvement, thanks @frederik-elwert!

@kmike kmike added this to the v1.6 milestone Dec 26, 2018
@dangra dangra merged commit 5d02aab into scrapy:master Dec 26, 2018
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 84.38%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants