Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] the strip() isnt needed after base64 encoding user pass #3519

Merged
merged 1 commit into from
Dec 26, 2018

Conversation

lee-hodg
Copy link

@lee-hodg lee-hodg commented Dec 4, 2018

No description provided.

Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good catch!

@kmike kmike changed the title the strip() isnt needed after base64 encoding user pass [MRG+1] the strip() isnt needed after base64 encoding user pass Dec 25, 2018
@kmike kmike added this to the v1.6 milestone Dec 26, 2018
@dangra dangra merged commit d473be2 into scrapy:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants