Fix item-pipeline example #3544

joaquingx · 2018-12-23T05:31:49Z

if item['price']: and if item['price_excludes_vat']: could return KeyError exception, this patch aims to solve it.

codecov · 2018-12-23T05:48:41Z

Codecov Report

Merging #3544 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #3544     +/-   ##
=========================================
+ Coverage   84.38%   84.48%   +0.1%     
=========================================
  Files         167      167             
  Lines        9376     9405     +29     
  Branches     1392     1397      +5     
=========================================
+ Hits         7912     7946     +34     
+ Misses       1206     1201      -5     
  Partials      258      258

Impacted Files	Coverage Δ
scrapy/core/downloader/handlers/http10.py	`100% <0%> (ø)`	⬆️
scrapy/commands/shell.py	`92.85% <0%> (ø)`	⬆️
scrapy/core/downloader/handlers/file.py	`100% <0%> (ø)`	⬆️
scrapy/settings/default_settings.py	`98.63% <0%> (+0.01%)`	⬆️
scrapy/core/downloader/handlers/http11.py	`92.53% <0%> (+0.02%)`	⬆️
scrapy/core/downloader/handlers/ftp.py	`98.24% <0%> (+0.03%)`	⬆️
scrapy/core/downloader/handlers/datauri.py	`93.75% <0%> (+0.41%)`	⬆️
scrapy/core/downloader/handlers/__init__.py	`83.63% <0%> (+3.63%)`	⬆️
scrapy/spiders/sitemap.py	`81.25% <0%> (+6.25%)`	⬆️
scrapy/extensions/telnet.py	`80.95% <0%> (+6.95%)`	⬆️

nasirhjafri · 2018-12-28T11:45:59Z

docs/topics/item-pipeline.rst

@@ -87,8 +87,8 @@ contain a price::
        vat_factor = 1.15

        def process_item(self, item, spider):
-            if item['price']:
-                if item['price_excludes_vat']:
+            if 'price' in item and item['price']:


Why not item.get('price') ?

You're right, I'll change it. Changed 👌

dangra · 2019-01-28T13:44:26Z

thanks

Update item-pipeline example

f85c915

nasirhjafri reviewed Dec 28, 2018

View reviewed changes

Improve syntax for readability

e1f8b55

dangra merged commit b5026b8 into scrapy:master Jan 28, 2019

kmike added this to the v1.6 milestone Jan 29, 2019

kmike added the docs label Jan 29, 2019

Fix item-pipeline example #3544

Fix item-pipeline example #3544

joaquingx commented Dec 23, 2018

codecov bot commented Dec 23, 2018 •

edited

nasirhjafri Dec 28, 2018

joaquingx Dec 28, 2018 •

edited

dangra commented Jan 28, 2019

Fix item-pipeline example #3544

Fix item-pipeline example #3544

Conversation

joaquingx commented Dec 23, 2018

codecov bot commented Dec 23, 2018 • edited

Codecov Report

nasirhjafri Dec 28, 2018

Choose a reason for hiding this comment

joaquingx Dec 28, 2018 • edited

Choose a reason for hiding this comment

dangra commented Jan 28, 2019

codecov bot commented Dec 23, 2018 •

edited

joaquingx Dec 28, 2018 •

edited