Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs for AWS_... settings. A follow-up to GH-2609. #3548

Merged
merged 1 commit into from Dec 26, 2018

Conversation

@kmike
Copy link
Member

@kmike kmike commented Dec 26, 2018

  • labels were after setting description, while they should have been before them;
  • BOT_NAME label was misplaced;
  • new options from #2609 only work with botocore;
  • document AWS_REGION_NAME introduced in #2609.
@kmike kmike added this to the v1.6 milestone Dec 26, 2018
@codecov
Copy link

@codecov codecov bot commented Dec 26, 2018

Codecov Report

Merging #3548 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3548   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         167      167           
  Lines        9376     9376           
  Branches     1392     1392           
=======================================
  Hits         7912     7912           
  Misses       1206     1206           
  Partials      258      258
@dangra dangra merged commit 76433fe into master Dec 26, 2018
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 4306886...71e4762
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra dangra deleted the fix-aws-settings-docs branch Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants