Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] change _retry() in RetryMiddleware log from debug to error #3566

Merged
merged 1 commit into from Jan 28, 2020

Conversation

BurnzZ
Copy link
Member

@BurnzZ BurnzZ commented Jan 4, 2019

Proposal/Suggestion for #3171

Fixes #3171

@codecov
Copy link

@codecov codecov bot commented Jan 4, 2019

Codecov Report

Merging #3566 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3566   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         169      169           
  Lines        9635     9635           
  Branches     1433     1433           
=======================================
  Hits         8231     8231           
  Misses       1156     1156           
  Partials      248      248
Impacted Files Coverage Δ
scrapy/downloadermiddlewares/retry.py 95.83% <100%> (ø) ⬆️

@BurnzZ BurnzZ changed the title [MRG] add customizable log levels for _retry() in RetryMiddleware [MRG] allow customizable log levels for _retry() in RetryMiddleware Jan 22, 2019
@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Apr 17, 2019

Please, see my comment in #3171.

@BurnzZ BurnzZ force-pushed the RetryMiddleware-logging-levels branch from e2ac7ad to 31b072e Compare Apr 27, 2019
@BurnzZ BurnzZ force-pushed the RetryMiddleware-logging-levels branch from 31b072e to a42d1e4 Compare Apr 27, 2019
@BurnzZ
Copy link
Member Author

@BurnzZ BurnzZ commented Apr 27, 2019

Updated the PR as per feedback in #3171.

Previous PR can be referenced in this branch: https://github.com/BurnzZ/scrapy/blob/RetryMiddleware-logging-levels-bak/scrapy/downloadermiddlewares/retry.py

kmike
kmike approved these changes Jan 23, 2020
Copy link
Member

@kmike kmike left a comment

I think that'd be a good change, thanks @BurnzZ!

@BurnzZ BurnzZ changed the title [MRG] allow customizable log levels for _retry() in RetryMiddleware [MRG+1] change _retry() in RetryMiddleware log from debug to error Jan 24, 2020
@Gallaecio Gallaecio merged commit a3b1689 into scrapy:master Jan 28, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants