Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that users must implement their own authentication result check #3615

Merged
merged 1 commit into from Feb 7, 2019

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 4, 2019

The example of form-based login could lead some users to think its authentication result
check was final. See https://stackoverflow.com/a/54410966/939364

This change should make it more obvious that users are expected to implement their
own logic to check whether authentication worked or not.

The example of form-based login could lead some users to think its authentication result
check was final. See https://stackoverflow.com/a/54410966/939364

This change should make it more obvious that users are expected to implement their
own logic to check whether authentication worked or not.
@codecov
Copy link

@codecov codecov bot commented Feb 4, 2019

Codecov Report

Merging #3615 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3615   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         167      167           
  Lines        9406     9406           
  Branches     1397     1397           
=======================================
  Hits         7950     7950           
  Misses       1199     1199           
  Partials      257      257

eLRuLL
eLRuLL approved these changes Feb 7, 2019
@eLRuLL eLRuLL merged commit b364bfb into scrapy:master Feb 7, 2019
3 checks passed
@kmike kmike added this to the v1.7 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants