Document that the crawl order is BFO for small numbers of start requests #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3621 +/- ##
==========================================
- Coverage 85.59% 85.03% -0.56%
==========================================
Files 164 164
Lines 9545 9545
Branches 1430 1430
==========================================
- Hits 8170 8117 -53
- Misses 1128 1175 +47
- Partials 247 253 +6
|
ejulio
reviewed
Feb 19, 2019
Gallaecio
force-pushed
the
bfo-for-few-requests
branch
from
16272b6 to
0411dda
Compare
kmike
reviewed
Jun 25, 2019
docs/faq.rst
Outdated
| in most cases. If you do want to crawl in true `BFO order`_, you can do it by | ||
| in most cases. | ||
|
|
||
| However, when the number of start request is small it always `crawls in BFO |
There was a problem hiding this comment.
I don't think it is correct: if there is a single request in start_requests, but then spider schedules many requests (e.g. after extracting links), behavior would be as usual, maybe besides first few requests.
Gallaecio
force-pushed
the
bfo-for-few-requests
branch
from
0411dda to
783de8a
Compare
|
I’ve switched to a completely new wording that I hope is more accurate and clear. |
|
Thanks @Gallaecio, I like the clarity of the explanation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1739