Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Document that the main entry point of downloader and spider middlewar… #3626

Merged
merged 1 commit into from Mar 15, 2019

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 13, 2019

…es is from_crawler()

Fixes #1789

@kmike kmike changed the title Document that the main entry point of downloader and spider middlewar… [MRG+1] Document that the main entry point of downloader and spider middlewar… Feb 13, 2019
@kmike
Copy link
Member

@kmike kmike commented Feb 13, 2019

Looks great, +1 to merge. Thanks @Gallaecio.

@kmike kmike added the docs label Feb 13, 2019
@codecov
Copy link

@codecov codecov bot commented Feb 13, 2019

Codecov Report

Merging #3626 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3626      +/-   ##
==========================================
+ Coverage    84.5%   84.52%   +0.01%     
==========================================
  Files         167      167              
  Lines        9406     9406              
  Branches     1397     1397              
==========================================
+ Hits         7949     7950       +1     
  Misses       1199     1199              
+ Partials      258      257       -1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️

@kmike kmike added this to the v1.7 milestone Feb 15, 2019
@kmike kmike removed this from the v1.7 milestone Feb 15, 2019
@Gallaecio Gallaecio merged commit d346b8c into scrapy:master Mar 15, 2019
3 checks passed
@kmike kmike added this to the v1.7 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants