[MRG+1] doc for creating custom cache storage backend. #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3692 +/- ##
==========================================
+ Coverage 84.54% 84.72% +0.18%
==========================================
Files 167 168 +1
Lines 9420 9461 +41
Branches 1402 1407 +5
==========================================
+ Hits 7964 8016 +52
+ Misses 1199 1188 -11
Partials 257 257
|
Gallaecio
requested changes
Mar 22, 2019
|
Hey @Gallaecio, sorry for replying so late. I have made the changes suggested by you. Can you review this again? Can we delay merging this? I am working on the documentation for creating custom cache policy. I think, we should include that as well inside this pull request. |
Gallaecio
approved these changes
Mar 27, 2019
|
@anubhavp28 Actually, I think that it is better to keep pull requests separate when possible. The smaller a pull request is, the easier it is to review it. |
Gallaecio
changed the title
Gallaecio
reviewed
May 27, 2019
| @@ -349,7 +349,7 @@ HttpCacheMiddleware | |||
| * :ref:`httpcache-storage-leveldb` | |||
|
|
|||
| You can change the HTTP cache storage backend with the :setting:`HTTPCACHE_STORAGE` | |||
| setting. Or you can also implement your own storage backend. | |||
| setting. Or you can also :ref:`implement your own storage backend. <httpcache-storage-custom>` | |||
There was a problem hiding this comment.
Suggested change
| setting. Or you can also :ref:`implement your own storage backend. <httpcache-storage-custom>` | |
| setting. Or you can also :ref:`implement your own storage backend <httpcache-storage-custom>`. |
|
Thanks @anubhavp28 for improved docs, and @Gallaecio for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3683