Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] doc for creating custom cache storage backend. #3692

Merged
merged 3 commits into from Jul 2, 2019

Conversation

@anubhavp28
Copy link
Contributor

@anubhavp28 anubhavp28 commented Mar 17, 2019

Fixes #3683

@codecov
Copy link

@codecov codecov bot commented Mar 17, 2019

Codecov Report

Merging #3692 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3692      +/-   ##
==========================================
+ Coverage   84.54%   84.72%   +0.18%     
==========================================
  Files         167      168       +1     
  Lines        9420     9461      +41     
  Branches     1402     1407       +5     
==========================================
+ Hits         7964     8016      +52     
+ Misses       1199     1188      -11     
  Partials      257      257
Impacted Files Coverage Δ
scrapy/http/__init__.py 100% <0%> (ø) ⬆️
scrapy/http/request/json_request.py 93.75% <0%> (ø)
scrapy/settings/default_settings.py 98.64% <0%> (ø) ⬆️
scrapy/downloadermiddlewares/redirect.py 96.77% <0%> (+0.05%) ⬆️
scrapy/item.py 98.48% <0%> (+0.07%) ⬆️
scrapy/extensions/feedexport.py 84.9% <0%> (+6.43%) ⬆️

docs/topics/downloader-middleware.rst Show resolved Hide resolved
docs/topics/downloader-middleware.rst Outdated Show resolved Hide resolved
docs/topics/downloader-middleware.rst Outdated Show resolved Hide resolved
docs/topics/downloader-middleware.rst Outdated Show resolved Hide resolved
docs/topics/downloader-middleware.rst Outdated Show resolved Hide resolved
docs/topics/downloader-middleware.rst Outdated Show resolved Hide resolved
@anubhavp28
Copy link
Contributor Author

@anubhavp28 anubhavp28 commented Mar 27, 2019

Hey @Gallaecio, sorry for replying so late. I have made the changes suggested by you. Can you review this again? Can we delay merging this? I am working on the documentation for creating custom cache policy. I think, we should include that as well inside this pull request.

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 27, 2019

@anubhavp28 Actually, I think that it is better to keep pull requests separate when possible. The smaller a pull request is, the easier it is to review it.

@Gallaecio Gallaecio changed the title doc for creating custom cache storage backend. [MRG+1] doc for creating custom cache storage backend. Mar 27, 2019
@@ -349,7 +349,7 @@ HttpCacheMiddleware
* :ref:`httpcache-storage-leveldb`

You can change the HTTP cache storage backend with the :setting:`HTTPCACHE_STORAGE`
setting. Or you can also implement your own storage backend.
setting. Or you can also :ref:`implement your own storage backend. <httpcache-storage-custom>`
Copy link
Member

@Gallaecio Gallaecio May 27, 2019

Suggested change
setting. Or you can also :ref:`implement your own storage backend. <httpcache-storage-custom>`
setting. Or you can also :ref:`implement your own storage backend <httpcache-storage-custom>`.

@kmike kmike merged commit 4c755f1 into scrapy:master Jul 2, 2019
1 of 2 checks passed
@kmike kmike added this to the v1.7 milestone Jul 2, 2019
@kmike
Copy link
Member

@kmike kmike commented Jul 2, 2019

Thanks @anubhavp28 for improved docs, and @Gallaecio for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants