Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing export column names #3696

Merged
merged 17 commits into from
Jun 26, 2022

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 22, 2019

Fixes #1008, fixes #3266

@Gallaecio Gallaecio changed the title Allow customizing export column names [WIP] Allow customizing export column names Mar 22, 2019
@Gallaecio Gallaecio force-pushed the allow-customizing-export-column-names branch 4 times, most recently from 7f29818 to 9000c8c Compare March 26, 2019 15:41
@Gallaecio Gallaecio changed the title [WIP] Allow customizing export column names Allow customizing export column names Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #3696 (892d339) into master (de0e2cc) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 892d339 differs from pull request most recent head ec5cf3e. Consider uploading reports for the commit ec5cf3e to get more accurate results

@@            Coverage Diff             @@
##           master    #3696      +/-   ##
==========================================
- Coverage   88.71%   88.58%   -0.14%     
==========================================
  Files         162      162              
  Lines       10740    10764      +24     
  Branches     1834     1842       +8     
==========================================
+ Hits         9528     9535       +7     
- Misses        939      953      +14     
- Partials      273      276       +3     
Impacted Files Coverage Δ
scrapy/settings/default_settings.py 98.76% <ø> (ø)
scrapy/core/downloader/handlers/ftp.py 98.38% <100.00%> (ø)
scrapy/core/downloader/webclient.py 94.65% <100.00%> (ø)
scrapy/exporters.py 100.00% <100.00%> (ø)
scrapy/extensions/httpcache.py 95.41% <100.00%> (ø)
scrapy/responsetypes.py 94.28% <100.00%> (+0.25%) ⬆️
scrapy/settings/__init__.py 93.44% <100.00%> (+0.37%) ⬆️
scrapy/utils/conf.py 93.75% <100.00%> (ø)
scrapy/utils/asyncgen.py 33.33% <0.00%> (-66.67%) ⬇️
scrapy/utils/spider.py 69.69% <0.00%> (-12.13%) ⬇️
... and 3 more

docs/topics/feed-exports.rst Outdated Show resolved Hide resolved
@Gallaecio Gallaecio force-pushed the allow-customizing-export-column-names branch from 3a2dd58 to ab13221 Compare December 17, 2019 13:06
scrapy/settings/__init__.py Outdated Show resolved Hide resolved
tests/test_feedexport.py Outdated Show resolved Hide resolved
@Gallaecio
Copy link
Member Author

Gallaecio commented May 27, 2022

@wRAR, @kmike: Should we consider this a potential candidate for 2.7?

@wRAR
Copy link
Member

wRAR commented May 27, 2022

I'm fine with that.

@Gallaecio Gallaecio added this to the 2.7 milestone May 27, 2022
scrapy/settings/__init__.py Outdated Show resolved Hide resolved
tests/test_feedexport.py Outdated Show resolved Hide resolved
@kmike
Copy link
Member

kmike commented Jun 26, 2022

Thanks @Gallaecio!

@kmike kmike merged commit 500dae8 into scrapy:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow defining field names that don't follow the restrictions of python variables Non-ascii field names
3 participants