[MRG+1] [Docs] CrawlSpider: update Rule docs #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3712 +/- ##
==========================================
- Coverage 85.59% 85.52% -0.08%
==========================================
Files 164 169 +5
Lines 9545 9830 +285
Branches 1430 1500 +70
==========================================
+ Hits 8170 8407 +237
- Misses 1128 1168 +40
- Partials 247 255 +8
|
Gallaecio
reviewed
Apr 1, 2019
|
Also updated the
|
kmike
reviewed
Apr 1, 2019
kmike
reviewed
Apr 1, 2019
| :class:`~scrapy.http.Request` objects (or any subclass of them). | ||
| the specified link extractor. This callback receives a :class:`~scrapy.http.Response` | ||
| as its first argument and must return either a single instance or an iterable of | ||
| :class:`~scrapy.item.Item`, ``dict`` and/or :class:`~scrapy.http.Request` objects |
elacuesta
changed the title
Gallaecio
reviewed
Apr 2, 2019
docs/topics/spiders.rst
Outdated
| the specified link extractor. This callback receives a :class:`~scrapy.http.Response` | ||
| as its first argument and must return either a single instance or an iterable of | ||
| :class:`~scrapy.item.Item`, ``dict`` and/or :class:`~scrapy.http.Request` objects | ||
| (or any subclass of them). |
There was a problem hiding this comment.
I still wonder if we should mention link_text in the documentation about the callback, since users will most often need to access that meta field from their callback.
There was a problem hiding this comment.
I agree, but I was concerned about duplicating the same content. I ended up basically copying the same text from the previous part, but adding "As mentioned above" to make it clear that it's not an accidental duplication but an intended remark.
kmike
changed the title
|
I think these changes are improvement to what we have in master, so +1 to merge them as-is. |
kmike
approved these changes
Jul 4, 2019
Gallaecio
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3711
More information at https://stackoverflow.com/q/55450472/939364