Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Docs - Tutorial - Minor grammar edits #3724

Merged
merged 4 commits into from Apr 5, 2019

Conversation

@float13
Copy link
Contributor

@float13 float13 commented Apr 5, 2019

I made a few small edits to docs/intro/tutorial.rst:

  • deleted apostrophe from "let's" to "lets"
  • deleted extra word "shell" which was repeated in reference link
  • changed "browser developer tools" to "browser's developer tools" (add apostrophe + s)
  • deleted 2 extra words from "(see section about ...)" to "(see ...)"

I did each edit on a separate commit in case you want to change or revert any of them.

Let me know if this is helpful. I'm new to Scrapy and I have a few other ideas of how to improve the docs.

If I make any more edits, does it make sense to do a separate branch/pull request per file?

@Gallaecio Gallaecio changed the title Docs - Tutorial - Minor grammar edits [MRG+1] Docs - Tutorial - Minor grammar edits Apr 5, 2019
@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Apr 5, 2019

Thanks!

If I make any more edits, does it make sense to do a separate branch/pull request per file?

Yes, it does.

@codecov
Copy link

@codecov codecov bot commented Apr 5, 2019

Codecov Report

Merging #3724 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3724   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files         168      168           
  Lines        9521     9521           
  Branches     1418     1418           
=======================================
  Hits         8083     8083           
  Misses       1184     1184           
  Partials      254      254

@kmike kmike merged commit d39feab into scrapy:master Apr 5, 2019
3 checks passed
@kmike
Copy link
Member

@kmike kmike commented Apr 5, 2019

Thanks @float13!

@kmike kmike added this to the v1.7 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants