Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover PEP 257 in the documentation policies #3748

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Apr 17, 2019

Based on a comment by @kmike.

@codecov
Copy link

@codecov codecov bot commented Apr 17, 2019

Codecov Report

Merging #3748 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3748   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         169      169           
  Lines        9635     9635           
  Branches     1433     1433           
=======================================
  Hits         8231     8231           
  Misses       1156     1156           
  Partials      248      248

@kmike
Copy link
Member

@kmike kmike commented Apr 17, 2019

Looks good, thanks @Gallaecio!

@kmike kmike merged commit 6e49c37 into scrapy:master Apr 17, 2019
3 checks passed
@kmike kmike added this to the v1.7 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants