Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added issue and PR template #3754

Closed
wants to merge 1 commit into from
Closed

Added issue and PR template #3754

wants to merge 1 commit into from

Conversation

@abhinavsagar
Copy link

@abhinavsagar abhinavsagar commented Apr 22, 2019

Fixes #3749

@codecov
Copy link

@codecov codecov bot commented Apr 22, 2019

Codecov Report

Merging #3754 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3754      +/-   ##
==========================================
+ Coverage   85.41%   85.42%   +0.01%     
==========================================
  Files         169      169              
  Lines        9635     9635              
  Branches     1433     1433              
==========================================
+ Hits         8230     8231       +1     
  Misses       1156     1156              
+ Partials      249      248       -1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️

@@ -0,0 +1,19 @@
**Actual Behaviour**
Copy link
Contributor

@Matthijsy Matthijsy Apr 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to the contributing to scrapy document https://docs.scrapy.org/en/master/contributing.html? And maybe add a line that questions about how to use scrapy should be posted on Stackoverflow?

<!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->


Screenshots of the change:
Copy link
Contributor

@Matthijsy Matthijsy Apr 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think that there will be screenshots often since there is not really an UI. Maybe also here add a link to the contributing page

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Apr 29, 2019

Please, see #3126

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jul 29, 2019

Thank you, but we are closing this pull request in favor of #3471.

@Gallaecio Gallaecio closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants