Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the METAREFRESH_IGNORE_TAGS setting #3768

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented May 8, 2019

Implements a new setting that can be used to fix #1422.

I actually believe that the default value should be an empty list, so that we follow an approach more similar to that of web browsers, and #1422 gets fixed automatically without requiring changing a setting. But these changes aim for backward compatibility.

@codecov
Copy link

@codecov codecov bot commented May 8, 2019

Codecov Report

Merging #3768 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3768      +/-   ##
==========================================
- Coverage   85.42%   85.42%   -0.01%     
==========================================
  Files         169      169              
  Lines        9635     9637       +2     
  Branches     1433     1433              
==========================================
+ Hits         8231     8232       +1     
  Misses       1156     1156              
- Partials      248      249       +1
Impacted Files Coverage Δ
scrapy/utils/response.py 85.41% <100%> (ø) ⬆️
scrapy/settings/default_settings.py 98.65% <100%> (ø) ⬆️
scrapy/downloadermiddlewares/redirect.py 96.82% <100%> (+0.05%) ⬆️
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️

Loading

@kmike
Copy link
Member

@kmike kmike commented Jun 25, 2019

Thanks @Gallaecio!

Should we keep #1422 open, as a place of discussion for a default, or should we create a separate ticket?

Loading

@kmike kmike merged commit c81d120 into scrapy:master Jun 25, 2019
3 checks passed
Loading
@kmike kmike added this to the v1.7 milestone Jun 25, 2019
@Gallaecio
Copy link
Member Author

@Gallaecio Gallaecio commented Jun 26, 2019

Should we keep #1422 open, as a place of discussion for a default, or should we create a separate ticket?

I’ve just created #3844 for it.

Loading

@kmike
Copy link
Member

@kmike kmike commented Jun 26, 2019

Thanks @Gallaecio!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants