[MRG+1] Fix form methods in FormRequest.from_response (#3777) #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csalazar
changed the title
Gallaecio
previously approved these changes
May 27, 2019
Gallaecio
changed the title
kmike
reviewed
May 28, 2019
scrapy/http/request/form.py
Outdated
|
|
||
| method = kwargs.pop('method', form.method).upper() | ||
| if method not in cls.valid_form_methods: | ||
| raise ValueError('Invalid form method in chosen form') |
There was a problem hiding this comment.
I wonder if we should follow standard more closely, and consider unknown and invalid methods as GET (see https://www.w3.org/TR/html5/sec-forms.html#element-attrdef-form-method):
The invalid value default for these attributes is the GET state. The missing value default for the method attribute is also the GET state. (There is no missing value default for the formmethod attribute.)
There was a problem hiding this comment.
Yep, I agree with that, I'm going to modify the PR.
Gallaecio
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3794 +/- ##
==========================================
+ Coverage 85.42% 85.43% +<.01%
==========================================
Files 169 169
Lines 9635 9638 +3
Branches 1433 1434 +1
==========================================
+ Hits 8231 8234 +3
Misses 1156 1156
Partials 248 248
|
Codecov Report
@@ Coverage Diff @@
## master #3794 +/- ##
=========================================
- Coverage 85.42% 85.4% -0.03%
=========================================
Files 169 169
Lines 9635 9687 +52
Branches 1433 1445 +12
=========================================
+ Hits 8231 8273 +42
- Misses 1156 1166 +10
Partials 248 248
|
|
Updated with Mikhail's feedback |
Gallaecio
approved these changes
Jun 7, 2019
Gallaecio
changed the title
Gallaecio
changed the title
kmike
reviewed
Jun 10, 2019
|
Thanks @csalazar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3777