Fix for issue #3798 LinkExtractor with Unique = False doesn't extract fully identical Links #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtract fully identical Links
Codecov Report
@@ Coverage Diff @@
## master #3799 +/- ##
==========================================
+ Coverage 85.42% 85.43% +<.01%
==========================================
Files 169 169
Lines 9635 9637 +2
Branches 1433 1433
==========================================
+ Hits 8231 8233 +2
Misses 1156 1156
Partials 248 248
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3799 +/- ##
==========================================
+ Coverage 85.42% 85.43% +<.01%
==========================================
Files 169 169
Lines 9635 9637 +2
Branches 1433 1433
==========================================
+ Hits 8231 8233 +2
Misses 1156 1156
Partials 248 248
|
Gallaecio
reviewed
May 29, 2019
| @@ -15,7 +15,7 @@ | |||
| from scrapy.utils.url import ( | |||
| url_is_from_any_domain, url_has_any_extension, | |||
| ) | |||
|
|
|||
| from scrapy.utils.python import unique as unique_list | |||
There was a problem hiding this comment.
💄 Could you move it into the group of import above, keeping the alphabetical sorting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3798