Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a double indexing of the scrapy.statscollectors module in the doc… #3806

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jun 3, 2019

…umentation

The issue is being reported by the CI system.

@Gallaecio Gallaecio changed the title Fix a double indexing of the scrapy.statscollectors module in the doc… [WIP] Fix a double indexing of the scrapy.statscollectors module in the doc… Jun 4, 2019
@Gallaecio Gallaecio force-pushed the statscollectors-currentmodule branch from 06bfbf1 to ea209a0 Jun 4, 2019
@codecov
Copy link

@codecov codecov bot commented Jun 4, 2019

Codecov Report

Merging #3806 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3806   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         169      169           
  Lines        9635     9635           
  Branches     1433     1433           
=======================================
  Hits         8231     8231           
  Misses       1156     1156           
  Partials      248      248

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Jun 4, 2019

Codecov Report

Merging #3806 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3806   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         169      169           
  Lines        9635     9635           
  Branches     1433     1433           
=======================================
  Hits         8231     8231           
  Misses       1156     1156           
  Partials      248      248

@Gallaecio Gallaecio changed the title [WIP] Fix a double indexing of the scrapy.statscollectors module in the doc… Fix a double indexing of the scrapy.statscollectors module in the doc… Jun 4, 2019
@kmike
Copy link
Member

@kmike kmike commented Jun 4, 2019

Thanks @Gallaecio!

@kmike kmike merged commit a3dab41 into scrapy:master Jun 4, 2019
1 of 2 checks passed
@Gallaecio Gallaecio deleted the statscollectors-currentmodule branch Jun 4, 2019
@kmike kmike added this to the v1.7 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants