Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Twisted<=19.2.0 for Python 3.4 #3825

Merged
merged 1 commit into from Jun 12, 2019
Merged

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jun 11, 2019

Twisted 19.2.0 is the final release with Python 3.4 support.

These changes are based on the setuptools documentation and PEP 508.

Fixes #3821

Copy link
Contributor

@victor-torres victor-torres left a comment

LGTM

@victor-torres
Copy link
Contributor

@victor-torres victor-torres commented Jun 11, 2019

I'd say to add some test cases for py3.4. Go for it if you have some time.
Anyway, seems like we should be dropping Python 3.4 support soon.

@dangra dangra merged commit 66c40d0 into scrapy:master Jun 12, 2019
1 of 2 checks passed
@dangra
Copy link
Member

@dangra dangra commented Jun 12, 2019

Anyway, seems like we should be dropping Python 3.4 support soon.

Let's drop Python 3.4 in for next release.

@kmike kmike added this to the v1.7 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants