This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hm, I could write some docs. The Settings-related tests... are a boatload.
Tbh, I don't even know where I should add a case there and where not, as I don't grasp the whole Settings-functionalities since they got the Attributes and priorities layers.
I will have a think on that, and need to find some time to parse that code.
I tried. Sorry to disappoint, it seems that's not something I can manage in a reasonable amount of time. Oh well, I found this: jdemaeyer@7fca7b5
Would these work? Actually not
But do we need those MW-changes over there, also?
Thanks for the hints!
I'm not sure if those tests now are suitable or good enough, probably not. But maybe you can give some more hints now that I did some work? :p
The paragraph in the docs also doesn't sound really awesome, but I didn't manage to make it more concise without sacrificing legibility for (likely non-native) readers. Improvements welcome.
edit: Let me squash those commits before you merge, in any case.
Move it to a section of its own, so that the scope of versionadded is clearer
Refactor the first two paragraph so that they do not speak in terms of before and after (more fitting for the release notes), but rather describe the current situation.
Removed the inline examples, as the example below show suffice.
Removed the note about deprecation handling; it was not 100% accurate (deprecation checks should still work, and happen when those objects are used at run time; fixing the paths of removed imports is was will not be there, but I don’t think that needs to be described explicitly)
@Gallaecio, many thanks for the work.
I'm sorry for dropping the ball on my scrapy contributions, but I don't currently have enough free time to continue them.
If you feel like finishing this PR, I totally wouldn't mind. But no pressure (from me).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.