Deprecate scrapy.utils.datatypes.MergeDict in favor of collections.ChainMap #3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3878 +/- ##
==========================================
- Coverage 85.56% 85.54% -0.02%
==========================================
Files 164 164
Lines 9551 9556 +5
Branches 1431 1432 +1
==========================================
+ Hits 8172 8175 +3
- Misses 1132 1133 +1
- Partials 247 248 +1
|
kmike
reviewed
Jul 15, 2019
Gallaecio
approved these changes
Jul 17, 2019
|
A good catch, thanks @elacuesta! |
|
By all means, thanks to you both @kmike and @Gallaecio 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
collections.ChainMapwhen available, fall back toscrapy.utils.datatypes.MergeDict(currently in use only inscrapy.loader.processors.MapCompose)