Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate scrapy.utils.datatypes.MergeDict in favor of collections.ChainMap #3878

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented Jul 14, 2019

Use collections.ChainMap when available, fall back to scrapy.utils.datatypes.MergeDict (currently in use only in scrapy.loader.processors.MapCompose)

@codecov
Copy link

@codecov codecov bot commented Jul 14, 2019

Codecov Report

Merging #3878 into master will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #3878      +/-   ##
==========================================
- Coverage   85.56%   85.54%   -0.02%     
==========================================
  Files         164      164              
  Lines        9551     9556       +5     
  Branches     1431     1432       +1     
==========================================
+ Hits         8172     8175       +3     
- Misses       1132     1133       +1     
- Partials      247      248       +1
Impacted Files Coverage Δ
scrapy/utils/datatypes.py 59.57% <0%> (-0.65%) ⬇️
scrapy/loader/processors.py 100% <100%> (ø) ⬆️

scrapy/utils/datatypes.py Outdated Show resolved Hide resolved
@kmike kmike added this to the v1.7 milestone Jul 17, 2019
@kmike kmike merged commit b2c013f into scrapy:master Jul 17, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Jul 17, 2019

A good catch, thanks @elacuesta!

@elacuesta elacuesta deleted the mergedict_to_chainmap branch Jul 17, 2019
@elacuesta
Copy link
Member Author

@elacuesta elacuesta commented Jul 17, 2019

By all means, thanks to you both @kmike and @Gallaecio 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants