Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConfigParser import in py2 #3896

Merged
merged 1 commit into from Jul 23, 2019
Merged

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented Jul 22, 2019

Fixes #3893, fixes #3889

Cleaning up my own mess 馃槄

@elacuesta
Copy link
Member Author

@elacuesta elacuesta commented Jul 22, 2019

For the sake of transparency, I took sources and ideas from https://stackoverflow.com/a/54536092

@codecov
Copy link

@codecov codecov bot commented Jul 22, 2019

Codecov Report

Merging #3896 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3896      +/-   ##
==========================================
+ Coverage   85.56%   85.56%   +<.01%     
==========================================
  Files         164      164              
  Lines        9565     9567       +2     
  Branches     1435     1436       +1     
==========================================
+ Hits         8184     8186       +2     
  Misses       1133     1133              
  Partials      248      248
Impacted Files Coverage 螖
scrapy/utils/conf.py 89.7% <100%> (+0.31%) 猬嗭笍

kmike
kmike approved these changes Jul 22, 2019
Copy link
Member

@kmike kmike left a comment

馃憤 Thanks @elacuesta!

@Gallaecio Gallaecio merged commit bc8672c into scrapy:master Jul 23, 2019
3 checks passed
@elacuesta elacuesta deleted the fix_configparser_import branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants