Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constrain on lxml version to avoid error when using Python 3.4 (#3912) #3918

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Added constrain on lxml version to avoid error when using Python 3.4 (#3912) #3918

merged 1 commit into from
Jul 31, 2019

Conversation

rennerocha
Copy link
Contributor

This fixes #3912 .
lxml 4.3.5 is the latest with Python 3.4 support.
This PR was created from the right branch (1.7)

Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rennerocha!

@dangra dangra merged commit c5b8cc4 into scrapy:1.7 Jul 31, 2019
@dangra
Copy link
Member

dangra commented Jul 31, 2019

Cherry-picked into master branch as a25e09e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants