Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory handling and error handling in utils.ssl.get_temp_key_info. #3920

Merged
merged 1 commit into from Jul 31, 2019

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Jul 30, 2019

Found in #3892. Tested on xenial with various pyOpenSSL and cryptography combinations.

@kmike
Copy link
Member

@kmike kmike commented Jul 30, 2019

I have no idea how it works, but as it fixes a segfault, you tested it, and all this code is disabled by default, +1 to merge it :)

kmike
kmike approved these changes Jul 30, 2019
@dangra dangra merged commit b01d012 into scrapy:master Jul 31, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants