Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Travis-ci build environment to previous default: Trusty #3923

Merged
merged 1 commit into from Jul 31, 2019

Conversation

dangra
Copy link
Member

@dangra dangra commented Jul 31, 2019

Travis-ci changed the default build environment to Xenial as explained in https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment
This causes builds meant for Debian Jessie to break as noted by @wRAR in #3917 (comment)

This change pins the environment to known working ubuntu trusty distribution prior to dropping Jessie support and upgrade to Xenial as base.

Closes #3917

Note: Backport this change to 1.7 branch once it is merged to master.

Travis-ci changed the default build environment to Xenial as explained in https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment
This causes builds meant for Debian Jessie to break as noted by @wRAR in #3917 (comment)

This change pins the environment to known working ubuntu trusty distribution prior to dropping Jessie support and upgrade to Xenial as base.

Closes #1369
@codecov
Copy link

@codecov codecov bot commented Jul 31, 2019

Codecov Report

Merging #3923 into master will increase coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3923      +/-   ##
==========================================
+ Coverage   84.86%   85.45%   +0.59%     
==========================================
  Files         165      165              
  Lines        9625     9625              
  Branches     1447     1447              
==========================================
+ Hits         8168     8225      +57     
+ Misses       1194     1146      -48     
+ Partials      263      254       -9
Impacted Files Coverage Δ
scrapy/pipelines/files.py 66.53% <0%> (+1.15%) ⬆️
scrapy/core/scraper.py 88.51% <0%> (+2.02%) ⬆️
scrapy/core/downloader/handlers/http11.py 92.53% <0%> (+2.61%) ⬆️
scrapy/extensions/feedexport.py 83.48% <0%> (+5.04%) ⬆️
scrapy/utils/ssl.py 52.77% <0%> (+5.55%) ⬆️
scrapy/core/downloader/tls.py 88.88% <0%> (+12.96%) ⬆️
scrapy/utils/boto.py 73.33% <0%> (+26.66%) ⬆️
scrapy/core/downloader/handlers/s3.py 95.16% <0%> (+32.25%) ⬆️

@dangra dangra requested review from kmike and Gallaecio Jul 31, 2019
@dangra dangra mentioned this pull request Jul 31, 2019
@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jul 31, 2019

If 1.8 will use Xenial, shouldn’t we do this on 1.7.x only?

@dangra
Copy link
Member Author

@dangra dangra commented Jul 31, 2019

If 1.8 will use Xenial, shouldn’t we do this on 1.7.x only?

Not really, builds on master branch are broken right now because of this and Xenial is to be upgraded as part of #3892

@lucywang000
Copy link
Member

@lucywang000 lucywang000 commented Jul 31, 2019

Cool! It's really confusing to see the builds fail each time even if it should succeed

@kmike
Copy link
Member

@kmike kmike commented Jul 31, 2019

I'd also prefer to fix it by moving forward with #3892, and have this PR against 1.7 only, but as it seems that #3892 still needs some discussion, I'm merging this PR, to fix builds, even if it is temporary.

@kmike kmike merged commit cdf7889 into master Jul 31, 2019
3 checks passed
@dangra dangra deleted the pin-build-environment branch Jul 31, 2019
@dangra
Copy link
Member Author

@dangra dangra commented Jul 31, 2019

Backported to 1.7 branch as 0287701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants