[GSoC 2019] Adds integration with Protego robots.txt parser. #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3935 +/- ##
==========================================
- Coverage 85.54% 85.39% -0.16%
==========================================
Files 166 167 +1
Lines 9681 9720 +39
Branches 1445 1455 +10
==========================================
+ Hits 8282 8300 +18
- Misses 1146 1162 +16
- Partials 253 258 +5
|
kmike
reviewed
Aug 5, 2019
|
Github references can now point to https://github.com/anubhavp28/protego Note: I’m delaying a proper review until scrapy/protego#1 is merged and a release with it published in PyPI. |
kmike
reviewed
Aug 19, 2019
scrapy/robotstxt.py
Outdated
| exc_info=sys.exc_info(), | ||
| extra={'spider': self.spider}) | ||
| robotstxt_body = '' | ||
| robotstxt_body = decode_robotstxt(robotstxt_body, spider, True) |
There was a problem hiding this comment.
could you please use keyword argument to pass boolean value (True), to make code more readable - here and in other places?
kmike
reviewed
Aug 19, 2019
tests/test_robotstxt_interface.py
Outdated
|
|
||
|
|
||
| class ProtegoRobotParserTest(BaseRobotParserTest, unittest.TestCase): | ||
| if not rerp_available(): |
There was a problem hiding this comment.
I think it should check for protego, not for rerp
kmike
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
I haven't tried running the code, but the code itself looks good to me, thanks @anubhavp28! +1 to merge.
anubhavp28
changed the title
Gallaecio
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[For Google Summer of Code 2019] Make Scrapy support Protego robots.txt parser.