Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all missing fields when a scrapes contract fails #3939

Merged
merged 3 commits into from Aug 8, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 5, 2019

Hijacking of #766 addressing remaining feedback.

@Gallaecio Gallaecio changed the title Improve scrapes contract [WIP] Improve scrapes contract Aug 8, 2019
@Gallaecio Gallaecio force-pushed the improve-scrapes-contract branch from 23f94d6 to 9119798 Compare Aug 8, 2019
@codecov
Copy link

@codecov codecov bot commented Aug 8, 2019

Codecov Report

Merging #3939 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3939   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files         167      167           
  Lines        9742     9742           
  Branches     1457     1457           
=======================================
  Hits         8286     8286           
  Misses       1194     1194           
  Partials      262      262
Impacted Files Coverage Δ
scrapy/contracts/default.py 86.36% <100%> (ø) ⬆️

@Gallaecio Gallaecio changed the title [WIP] Improve scrapes contract Improve scrapes contract Aug 8, 2019
@Gallaecio Gallaecio changed the title Improve scrapes contract Report all missing fields when a scrapes contract fails Aug 8, 2019
@kmike kmike merged commit 73d1b4b into scrapy:master Aug 8, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Aug 8, 2019

Looks good, thanks @Gallaecio and @tpeng!

@kmike kmike added this to the v1.8 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants