Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Simplify version reporting #3946

Merged
merged 2 commits into from Aug 10, 2019
Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Aug 7, 2019

After the recent updates of #3892 the minimum package versions for w3lib and pyOpenSSL were upgraded beyond the cases considered in the existing checks, I think those checks are not needed anymore.

Also, I'm sure there is a historical reason for catching ImportError on cryptography, but it is also required in setup.py so it should always be available for import.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #3946 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #3946     +/-   ##
=========================================
+ Coverage   84.96%   85.16%   +0.2%     
=========================================
  Files         166      167      +1     
  Lines        9681     9734     +53     
  Branches     1445     1457     +12     
=========================================
+ Hits         8225     8290     +65     
+ Misses       1194     1182     -12     
  Partials      262      262
Impacted Files Coverage Δ
scrapy/utils/versions.py 100% <100%> (+21.42%) ⬆️
scrapy/utils/ssl.py 52.5% <100%> (+5.27%) ⬆️
scrapy/utils/project.py 75.43% <0%> (-0.93%) ⬇️
scrapy/http/request/__init__.py 100% <0%> (ø) ⬆️
scrapy/utils/curl.py 100% <0%> (ø)
scrapy/extensions/feedexport.py 81.65% <0%> (+3.21%) ⬆️

@Gallaecio Gallaecio changed the title Simplify version reporting [MRG+1] Simplify version reporting Aug 8, 2019
scrapy/utils/versions.py Outdated Show resolved Hide resolved
kmike
kmike approved these changes Aug 8, 2019
Copy link
Member

@kmike kmike left a comment

👍

@kmike kmike merged commit 2f0c46e into scrapy:master Aug 10, 2019
2 checks passed
@elacuesta elacuesta deleted the simplify_versions branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants