-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete version checks #3950
Conversation
16.0.0 is currently the minimum supported version
16.2.0 is currently the minimum supported version
…4.0.0) 16.0.0 is currently the minimum supported version
service_identity.exceptions.CertificateError is available in the current minimum version (16.0.0)
16.0.0 is currently the minimum supported version
Signed-off-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3950 +/- ##
==========================================
+ Coverage 85.11% 85.31% +0.19%
==========================================
Files 167 167
Lines 9744 9709 -35
Branches 1457 1453 -4
==========================================
- Hits 8294 8283 -11
+ Misses 1188 1168 -20
+ Partials 262 258 -4
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3950 +/- ##
==========================================
+ Coverage 85.11% 85.31% +0.19%
==========================================
Files 167 167
Lines 9744 9709 -35
Branches 1457 1453 -4
==========================================
- Hits 8294 8283 -11
+ Misses 1188 1168 -20
+ Partials 262 258 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really prefer style changes only in the affected lines when a change is not specifically about style changes, otherwise reviewing can become a bit more annoying to me. But your changes, @elacuesta, are always worth the trouble :)
I know, I know, sorry about that 😅 |
Thanks @elacuesta! |
Removing more version checks after bumping minimum package versions in #3892 (Twisted, pyOpenSSL)
I must admit, in the last commit I might have got too excited about indentation and PEP8 (but not the 79-char limit), so feel free to disregard that one (hopefully you won't 🤞 😄)