Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete version checks #3950

Merged
merged 9 commits into from Aug 12, 2019
Merged

Remove obsolete version checks #3950

merged 9 commits into from Aug 12, 2019

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented Aug 9, 2019

Removing more version checks after bumping minimum package versions in #3892 (Twisted, pyOpenSSL)

I must admit, in the last commit I might have got too excited about indentation and PEP8 (but not the 79-char limit), so feel free to disregard that one (hopefully you won't 馃 馃槃)

elacuesta added 9 commits Aug 9, 2019
16.0.0 is currently the minimum supported version
16.2.0 is currently the minimum supported version
鈥4.0.0)

16.0.0 is currently the minimum supported version
service_identity.exceptions.CertificateError is available in the current minimum version (16.0.0)
16.0.0 is currently the minimum supported version
Signed-off-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
@elacuesta elacuesta closed this Aug 9, 2019
@elacuesta elacuesta reopened this Aug 9, 2019
@codecov
Copy link

@codecov codecov bot commented Aug 9, 2019

Codecov Report

Merging #3950 into master will increase coverage by 0.19%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##           master    #3950      +/-   ##
==========================================
+ Coverage   85.11%   85.31%   +0.19%     
==========================================
  Files         167      167              
  Lines        9744     9709      -35     
  Branches     1457     1453       -4     
==========================================
- Hits         8294     8283      -11     
+ Misses       1188     1168      -20     
+ Partials      262      258       -4
Impacted Files Coverage 螖
scrapy/core/downloader/tls.py 86.04% <81.25%> (+10.12%) 猬嗭笍
scrapy/core/downloader/contextfactory.py 96.15% <96%> (+21.15%) 猬嗭笍
scrapy/core/downloader/handlers/http11.py 92.91% <96.55%> (+2.98%) 猬嗭笍

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Aug 9, 2019

Codecov Report

Merging #3950 into master will increase coverage by 0.19%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##           master    #3950      +/-   ##
==========================================
+ Coverage   85.11%   85.31%   +0.19%     
==========================================
  Files         167      167              
  Lines        9744     9709      -35     
  Branches     1457     1453       -4     
==========================================
- Hits         8294     8283      -11     
+ Misses       1188     1168      -20     
+ Partials      262      258       -4
Impacted Files Coverage 螖
scrapy/core/downloader/tls.py 86.04% <81.25%> (+10.12%) 猬嗭笍
scrapy/core/downloader/contextfactory.py 96.15% <96%> (+21.15%) 猬嗭笍
scrapy/core/downloader/handlers/http11.py 92.91% <96.55%> (+2.98%) 猬嗭笍

@kmike kmike added this to the v1.8 milestone Aug 9, 2019
Copy link
Member

@Gallaecio Gallaecio left a comment

I really prefer style changes only in the affected lines when a change is not specifically about style changes, otherwise reviewing can become a bit more annoying to me. But your changes, @elacuesta, are always worth the trouble :)

@elacuesta
Copy link
Member Author

@elacuesta elacuesta commented Aug 12, 2019

I know, I know, sorry about that 馃槄
In my defense, I suspected there should be a way to view only a subset of the changes, and indeed it seems like Githhub does allow to select a specific range of commits to review: the first 8 commits can be seen at https://github.com/scrapy/scrapy/pull/3950/files/d5dcc5eaef80ef383dff90f19349c0e06f1836a6. The version-specific changes are more obvious that way in the downloader handler file.

@kmike kmike merged commit a95de71 into scrapy:master Aug 12, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Aug 12, 2019

Thanks @elacuesta!

@elacuesta elacuesta deleted the version_updates branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants