Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Scrapy 1.8.0 in the release notes #3952

Merged
merged 3 commits into from Oct 29, 2019
Merged

Cover Scrapy 1.8.0 in the release notes #3952

merged 3 commits into from Oct 29, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 12, 2019

Last covered commit: 7731814
Also covers #4092

@Gallaecio Gallaecio requested review from dangra, kmike and wRAR Aug 12, 2019
wRAR
wRAR approved these changes Aug 12, 2019
@codecov
Copy link

@codecov codecov bot commented Aug 13, 2019

Codecov Report

Merging #3952 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3952      +/-   ##
==========================================
+ Coverage   85.67%   85.68%   +0.01%     
==========================================
  Files         165      165              
  Lines        9734     9734              
  Branches     1463     1463              
==========================================
+ Hits         8340     8341       +1     
  Misses       1136     1136              
+ Partials      258      257       -1
Impacted Files Coverage Δ
scrapy/logformatter.py 90.47% <ø> (ø) ⬆️
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️

@codecov
Copy link

@codecov codecov bot commented Aug 13, 2019

Codecov Report

Merging #3952 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #3952     +/-   ##
=========================================
- Coverage   85.35%   85.16%   -0.2%     
=========================================
  Files         167      167             
  Lines        9699     9734     +35     
  Branches     1453     1457      +4     
=========================================
+ Hits         8279     8290     +11     
- Misses       1162     1182     +20     
- Partials      258      262      +4
Impacted Files Coverage Δ
scrapy/core/downloader/contextfactory.py 75% <0%> (-21.16%) ⬇️
scrapy/core/downloader/tls.py 75.92% <0%> (-10.13%) ⬇️
scrapy/core/downloader/handlers/http11.py 89.92% <0%> (-2.99%) ⬇️

@Gallaecio Gallaecio marked this pull request as ready for review Oct 29, 2019
@Gallaecio Gallaecio merged commit 94f060f into scrapy:master Oct 29, 2019
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants