This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Gallaecio I have considered your comments and modified the code ..
I have a note, the ImagesPipeline inherits from the FilesPipeline and it implements from_settings method just the same except for getting the store_uri, I could add the ftp username and password extraction to that method as well, but I suggest creating one method in FilesPipeline that does this implementation and takes store identification parameter and this method would be called by the two from_settings methods of FilesPipeline and ImagesPipeline
@Gallaecio I am working on the test now but there's something I wanna understand, the line uri = os.environ.get('ENVVAR'), how to know the value of the env var. If the test is to be written like for S3 and GCS, it would be FTP_TEST_FILE_URI , but in test_feedexport.FTPFeedStorageTest , FEEDTEST_FTP_URI is used.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.